[PATCH] D87126: [MachOYAML] Allow handcrafting custom contents for DWARF sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/MachOEmitter.cpp:288
               "wrote too much data somewhere, section offsets don't line up");
-        if (0 == strncmp(&Sec.segname[0], "__DWARF", sizeof(Sec.segname))) {
-          StringRef SectName(Sec.sectname,
----------------
jhenderson wrote:
> Seems like removing this is unrelated to the patch description? Possibly it just means you need to add a comment to the description saying something like "this allows us to remove a limitation..."
The comment is good, but I was actually referring to the patch description, which doesn't explain what we are actually allowing now here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87126/new/

https://reviews.llvm.org/D87126