[PATCH] D86859: [Coroutine] Make dealing with alloca spills more robust

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:674
+
+  void visitLoadInst(LoadInst &) {}
 
----------------
Does a load from an alloca need to be rewritten?


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:679
   // alloca and therefore we need to copy.
-  void visitStoreInst(StoreInst &SI) { PI.setAborted(&SI); }
+  void visitStoreInst(StoreInst &SI) { PI.setEscaped(&SI); }
 
----------------
If the use is the pointer, should the store be rewritten if it is dominated by coro.begin?


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:694
+
+  void visitGetElementPtrInst(GetElementPtrInst &GEPI) {
+    // The base visitor will adjust Offset accordingly.
----------------
Is a normal function call needed to be handled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86859/new/

https://reviews.llvm.org/D86859