[PATCH] D85961: [Fixed Point] Add floating point methods to APFixedPoint.

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 22:30:31 PDT 2020


rjmccall added a comment.

> Would it be completely unthinkable to "promote" calculations to a larger FP type (both here and in codegen) if the exponent bits are insufficient to hold the necessary scaling?

You could have the same problem with float/bfloat and a 128-bit fixed-point type, right?  128-bit integer types aren't at all ridiculous.  I think this is something you should accommodate properly in your design; I don't think it's that problematic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85961/new/

https://reviews.llvm.org/D85961



More information about the llvm-commits mailing list