[PATCH] D86859: [Coroutine] Make dealing with alloca spills more robust

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:643
+// If %b is an alias of %a and will be used after CoroBegin, this will be broken
+// and there is nothing we can do about it.
 namespace {
----------------
lxfind wrote:
> ChuanqiXu wrote:
> > Would there be cast* or GEP instruction of `Alloca` before Coro.Begin? If it is, it seems like we need to visit all the use of Alloca in AllocaVisitor
> Yes that's exactly what we are doing in the visitor.
Sorry, I made a mistake. It is right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86859/new/

https://reviews.llvm.org/D86859