[PATCH] D86947: [ms] [llvm-ml] Add support for size queries in MASM

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6631
+             .CaseLower("real4", 32)
+             .CaseLower("real8", 64)
+             .Default(0);
----------------
can you cover some more of these with tests, and some more of the keywords (say, lengthof) too?


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6634
+  if (Size) {
+    return false;
+  }
----------------
no tabs -- please run clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86947/new/

https://reviews.llvm.org/D86947