[PATCH] D84547: [ConstraintElimination] Add constraint elimination pass.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 3 13:38:47 PDT 2020
fhahn updated this revision to Diff 289801.
fhahn added a comment.
Remove unnecessary variable, address comments & rebase.
In D84547#2254414 <https://reviews.llvm.org/D84547#2254414>, @spatel wrote:
> In D84547#2253306 <https://reviews.llvm.org/D84547#2253306>, @fhahn wrote:
>
>> In D84547#2251796 <https://reviews.llvm.org/D84547#2251796>, @spatel wrote:
>>
>>> LGTM
>>
>> Thanks! How should we proceed with the prerequisite patches adding the constraint system? Should I just add reviewers for them as well?
>
> Sure - add similar reviewers as listed on this review. I just see some potential cosmetic improvements, but others may want to comment.
SGTM & done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84547/new/
https://reviews.llvm.org/D84547
Files:
llvm/include/llvm/Analysis/ConstraintSystem.h
llvm/include/llvm/InitializePasses.h
llvm/include/llvm/Transforms/Scalar.h
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
llvm/lib/Transforms/Scalar/CMakeLists.txt
llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
llvm/lib/Transforms/Scalar/Scalar.cpp
llvm/test/Transforms/ConstraintElimination/dom.ll
llvm/test/Transforms/ConstraintElimination/geps.2d.ll
llvm/test/Transforms/ConstraintElimination/geps.ll
llvm/test/Transforms/ConstraintElimination/i128.ll
llvm/test/Transforms/ConstraintElimination/loops.ll
llvm/test/Transforms/ConstraintElimination/mixed.ll
llvm/test/Transforms/ConstraintElimination/uge.ll
llvm/test/Transforms/ConstraintElimination/ugt-ule.ll
llvm/test/Transforms/ConstraintElimination/ule.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84547.289801.patch
Type: text/x-patch
Size: 33992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200903/28f30479/attachment.bin>
More information about the llvm-commits
mailing list