[PATCH] D86863: [EarlyCSE] Verify hash code in regression tests

[Bryan Chan via Phabricator via llvm-commits]

bryanpkc added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/ConstProp/math-1.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -early-cse -earlycse-debug-hash -S -o - %s | FileCheck %s
+
----------------
spatel wrote:
> Several tests like this are in the InstSimplify test directory, but not using -instsimplify directly. I think it would be better to update them to not use -early-cse at all.
> 
> Also, if there is some whitespace issue causing the entire file to update here, it would be better to fix that as a preliminary cleanup.
Do you mean I should replace `-early-cse` with `-inst-simplify` in these tests?

I have got rid of the whitespace-related diffs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86863/new/

https://reviews.llvm.org/D86863