[PATCH] D87098: [SVE][CodeGen] Fix DAGCombiner::ForwardStoreValueToDirectLoad for scalable vectors

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 12:29:20 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14784
+  if (LdStScalable && DAG.getDataLayout().isBigEndian())
+    return SDValue();
+
----------------
Add comments to explain these bailouts?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14810
+  else
+    STCoversLD = (Offset >= 0) && (Offset * 8 + LdMemSize.getFixedSize() <=
+                                   StMemSize.getFixedSize());
----------------
Probably you could make this math work for scalable vectors, but it probably doesn't really matter at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87098/new/

https://reviews.llvm.org/D87098



More information about the llvm-commits mailing list