[PATCH] D87019: [DebugInfo] Fix emitting DWARF64 .debug_rnglists sections (13/19).

Thu Sep 3 12:23:02 PDT 2020

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, except possible test tidyup.

================
Comment at: llvm/test/DebugInfo/X86/split-dwarf-v5-ranges.ll:24-31
+; DWARF32: 0x00000010: [DW_RLE_base_addressx]:  0x0000000000000000
+; DWARF32: 0x00000012: [DW_RLE_offset_pair  ]:  0x0000000000000001, 0x000000000000000c => [0x0000000000000001, 0x000000000000000c)
+; DWARF32: 0x00000015: [DW_RLE_offset_pair  ]:  0x000000000000000e, 0x0000000000000013 => [0x000000000000000e, 0x0000000000000013)
+; DWARF32: 0x00000018: [DW_RLE_end_of_list  ]
+; DWARF64: 0x0000001c: [DW_RLE_base_addressx]:  0x0000000000000000
+; DWARF64: 0x0000001e: [DW_RLE_offset_pair  ]:  0x0000000000000001, 0x000000000000000c => [0x0000000000000001, 0x000000000000000c)
+; DWARF64: 0x00000021: [DW_RLE_offset_pair  ]:  0x000000000000000e, 0x0000000000000013 => [0x000000000000000e, 0x0000000000000013)
----------------
Could you use https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-numeric-substitution-blocks to make these offsets relative to the offset in the offsets list, so they don't have to be duplicated for DWARF32/DWARF64?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87019/new/

https://reviews.llvm.org/D87019