[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 11:35:55 PDT 2020


lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

I feel like this may be trying to do too many things at once.
Was there an RFC?
There are several patches here:

1. langref
2. llvm side of the patch (maybe should be in the previous patch)
3. `SideEntry` changes - missing astdump changes, serialization/deserialization
4. the rest of the owl



================
Comment at: clang/lib/CodeGen/CGCleanup.cpp:777
+
+      // mark EHa scope end for fall-through flow
+      if (IsEHa && getInvokeDest())
----------------
Here and elsewhere, the comments start from Capital Letter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344



More information about the llvm-commits mailing list