[PATCH] D86750: GlobalISel: Port smarter known bits for umin/umax from DAG

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 11:21:22 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp:725-726
+
+  EXPECT_EQ(0u, KnownUmax.Zero.getZExtValue());
+  EXPECT_EQ(0xffffffffffffff00, KnownUmax.One.getZExtValue());
+}
----------------
foad wrote:
> These lines look spurious, or did you mean to test something different here?
Not sure what you mean


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86750/new/

https://reviews.llvm.org/D86750



More information about the llvm-commits mailing list