[PATCH] D86952: [MIRVRegNamer] MachineInstr StableHashing.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 10:26:07 PDT 2020


plotfi added a comment.

In D86952#2254880 <https://reviews.llvm.org/D86952#2254880>, @paquette wrote:

> Oh wait the tests already test what I was concerned about. LGTM with minor nits.
>
> (although decoupling the tests from mir-canon would be nice, since this is supposed to be standalone)

Cool. I am planning to write some tests for the MO types the MIRCanon tests aren't already covering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86952/new/

https://reviews.llvm.org/D86952



More information about the llvm-commits mailing list