[PATCH] D87034: [KnownBits] Implement accurate unsigned and signed max and min

Thu Sep 3 09:52:08 PDT 2020

foad added a comment.

In D87034#2254131 <https://reviews.llvm.org/D87034#2254131>, @RKSimon wrote:

> In D87034#2252892 <https://reviews.llvm.org/D87034#2252892>, @foad wrote:
>
>> In D87034#2252539 <https://reviews.llvm.org/D87034#2252539>, @RKSimon wrote:
>>
>>> Can you replace the implementations in SelectionDAG::computeKnownBits with these?
>>
>> Yes, that's the idea, and the same in GlobalISel and in ValueTracking.
>
> Sorry, what I meant was are there any codegen test diffs if you replace SelectionDAG::computeKnownBits with this implementation?

No, using it in SelectionDAG doesn't affect any existing tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87034/new/

https://reviews.llvm.org/D87034