[PATCH] D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19).
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 3 09:20:36 PDT 2020
ikudrin added inline comments.
================
Comment at: llvm/test/DebugInfo/X86/dwarf64-support.ll:6
+; should be ignored for earlier versions.
+; RUN: llc -mtriple=x86_64 -dwarf-version=2 -dwarf64 -filetype=obj %s -o - | \
+; RUN: llvm-dwarfdump -debug-line - | \
----------------
MaskRay wrote:
> If `-dwarf-version=2 -dwarf64` does not make sense, shouldn't the combo be errored to prevent misuse?
I am not sure where to add that check and reporting. It looks like for internal tools erroneous combinations are just ignored. For example, for NVPTX, setting the DWARF version is silently ignored (see lines 372-374 in `DwarfDebug.cpp`). Thus, my change just follows the crowd.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87011/new/
https://reviews.llvm.org/D87011
More information about the llvm-commits
mailing list