[PATCH] D73739: Exception support for basic block sections

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added a subscriber: snehasish.
rahmanl added a comment.

In D73739#2253361 <https://reviews.llvm.org/D73739#2253361>, @modimo wrote:

> I think with this alongside the recently committed MachineFunctionSplitter (MFS) the MFS phase is a good place to split out EH landing pads in both profile and non-profile code. A small change in MFS will enable EH LP splits in profiling given they should always be cold. I think in non-profile mode a sub-flag can be added like -mfs-split-LP-only where EH LPs are always split out. Enabling a general static-analysis splitting could also be interesting but outside of EH LPs I'm not certain there's guaranteed gains in other scenarios.

Yes @modimo .You're right that with a minimal change MachineFunctionSplitter can simply place all the EH pads into the cold section. I also see your point about splitting EH pads in non-profiled code . I believe MBFI assigns static frequencies in case profiles are missing and that can be used by MachineFunctionSplitter (@snehasish to confirm?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739