[PATCH] D87067: [llvm-symbolizer] Add back --use-symbol-table=true

Thu Sep 3 08:25:15 PDT 2020

MaskRay added a comment.

In D87067#2254066 <https://reviews.llvm.org/D87067#2254066>, @jhenderson wrote:

> In D87067#2254053 <https://reviews.llvm.org/D87067#2254053>, @jhenderson wrote:
>
>> Do you plan to add more --use-symbol-table tests (there are currently no others)?
>
> Never mind this question - I hadn't registered that the option was missing completely. Did `--use-symbol-table=false` (or some equivalent option) previously do something? If so, wemight want to add it back (with testing), as my understanding is that you didn't remove it deliberately.

`--use-symbol-table=false` did something previously but I cannot find it in code search. `--use-symbol-table=true` was a strange option name but was used previously by asan_symbolize.py (in llvm-project) and elsewhere (I don't know why they used it). `--use-symbol-table` can override function names with .symtab information, which supposedly has at least some debugging meanings. We can bring it back when proper tests are added.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87067/new/

https://reviews.llvm.org/D87067