[PATCH] D87023: [DebugInfo] Fix emitting DWARF64 .debug_names sections (16/19).

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp:273
       Asm->OutStreamer->AddComment("Offset in Bucket " + Twine(i));
-      Asm->emitLabelDifference(Hash->Sym, Base, sizeof(uint32_t));
+      Asm->emitLabelDifference(Hash->Sym, Base, Asm->getDwarfOffsetByteSize());
     }
----------------
dblaikie wrote:
> Where is this one tested? Is this offset rendered in the dump output at all?
The line emits offsets to entries. They are rendered in the dump after `Entry @`. They are not checked in the test directly, but as far as `llvm-dwarfdump` can interpret the section and find entries with expected information, we assume that the offsets are emitted properly.


================
Comment at: llvm/test/DebugInfo/X86/debug-names-dwarf64.ll:26
+; CHECK-NEXT:   Compilation Unit offsets [
+; CHECK-NEXT:     CU[0]: 0x00000000
+; CHECK-NEXT:   ]
----------------
dblaikie wrote:
> Is this a 64 bit offset & should be rendered as such?
Took a note for improving `llvm-dwarfdump` in the future. Right now the offsets are dumped as 32-bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87023/new/

https://reviews.llvm.org/D87023