[PATCH] D87061: Handle masked loads and stores in MemoryLocation/Dependence

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 04:35:51 PDT 2020


kparzysz added inline comments.


================
Comment at: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:472
+          continue;
+        return MemDepResult::getClobber(II);
+      }
----------------
efriedma wrote:
> What benefit are you getting here that's better than just falling through to the call to getModRefInfo()?
The testcase (coming in the next diff) no longer works without this code.

Originally, I added this part to help with my work on EarlyCSE and DSE, but now that it's all complete, the motivating testcase works even without this part above.  Still, it does seem to make a difference, so perhaps it could stay.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87061/new/

https://reviews.llvm.org/D87061



More information about the llvm-commits mailing list