[PATCH] D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19).

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

In D87011#2252628 <https://reviews.llvm.org/D87011#2252628>, @dblaikie wrote:

> Worth testing that the length field or other parts of the line table were written correctly per the format? Or is that already/going to be tested elsewhere? (if this is the first patch that makes debug_line able to be written in DWARF64, then I'd expect it to be testing any parts of the line table that are different/noteworthy in DWARF64 - possibly using assembly testing, but if llvm-dwarfdump's DWARF64 parsing support is well tested independently, then I guess it's good to just use it here too, like for any other tests)

The code that emits these tables is already tested with `llvm/test/MC/ELF/gen-dwarf64.s`. `llvm-dwarfdump` was updated in advance and ready to parse DWARF64 debug info, so we can trust it in the tests and do not need to overcomplicate them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87011/new/

https://reviews.llvm.org/D87011