[PATCH] D87021: [DebugInfo] Fix emitting DWARF64 type units (14/19).
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 2 21:44:00 PDT 2020
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good.
General feedback: If you can include the original C source code and whatever compile command was needed to generate the IR in any tests (this includes other patches I've already approved, if possible - not vital, many of the tests have very small IR that's pretty easy to read, but it's a "nice to have") that'd be handy! Makes it easier to eyeball the dump output and understand what it's expecting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87021/new/
https://reviews.llvm.org/D87021
More information about the llvm-commits
mailing list