[PATCH] D87023: [DebugInfo] Fix emitting DWARF64 .debug_names sections (16/19).

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp:273
       Asm->OutStreamer->AddComment("Offset in Bucket " + Twine(i));
-      Asm->emitLabelDifference(Hash->Sym, Base, sizeof(uint32_t));
+      Asm->emitLabelDifference(Hash->Sym, Base, Asm->getDwarfOffsetByteSize());
     }
----------------
Where is this one tested? Is this offset rendered in the dump output at all?


================
Comment at: llvm/test/DebugInfo/X86/debug-names-dwarf64.ll:9
+; CHECK-NEXT: 0x00000000:       Compile Unit: {{.+}}, format = DWARF64,
+; CHECK:      0x[[VARDIE:.+]]:  DW_TAG_variable
+; CHECK-NEXT:                     DW_AT_name ("foo")
----------------
I'd probably include the 0x in the match - so the later reference to this match doesn't have to specify the 0x too.


================
Comment at: llvm/test/DebugInfo/X86/debug-names-dwarf64.ll:26
+; CHECK-NEXT:   Compilation Unit offsets [
+; CHECK-NEXT:     CU[0]: 0x00000000
+; CHECK-NEXT:   ]
----------------
Is this a 64 bit offset & should be rendered as such?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87023/new/

https://reviews.llvm.org/D87023