[PATCH] D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/CSKY.def:6
+
+ELF_RELOC(R_CKCORE_NONE                 ,       0)
+ELF_RELOC(R_CKCORE_ADDR32               ,       1)
----------------
MaskRay wrote:
> For relocation type changes, we have tests in test/tools/llvm-readobj/ELF/reloc-types-elf-*.test. I don't know replicating every value is useful (you'll probably just copy and paste the value anyway), but having a few should not hurt.
Sorry to know what your meaning less.  Should I add test under `test/tools/llvm-readobj/ELF/reloc-types-elf-*.test`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86610/new/

https://reviews.llvm.org/D86610