[PATCH] D87067: [llvm-symbolizer] Add back --use-symbol-table=true

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 289618.
MaskRay added a comment.

Add a test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87067/new/

https://reviews.llvm.org/D87067

Files:
  llvm/test/tools/llvm-symbolizer/use-symbol-table.s
  llvm/tools/llvm-symbolizer/Opts.td


Index: llvm/tools/llvm-symbolizer/Opts.td
===================================================================
--- llvm/tools/llvm-symbolizer/Opts.td
+++ llvm/tools/llvm-symbolizer/Opts.td
@@ -67,3 +67,5 @@
 // Compatibility aliases for pprof's symbolizer.
 def : Flag<["-"], "demangle=true">, Alias<demangle>, HelpText<"Alias for --demangle">;
 def : Flag<["-"], "demangle=false">, Alias<no_demangle>, HelpText<"Alias for --no-demangle">;
+// Compatibility no-op options.
+def : Flag<["--"], "use-symbol-table=true">;
Index: llvm/test/tools/llvm-symbolizer/use-symbol-table.s
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-symbolizer/use-symbol-table.s
@@ -0,0 +1,7 @@
+# REQUIRES: x86-registered-target
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64 -g %s -o %t.o
+
+## --use-symbol-table=true is used by old asan_symbolize.py and Android ndk
+## ndk-stack.py. Keep it as a no-op compatibility option for a while.
+# RUN: llvm-symbolizer --use-symbol-table=true %t.o


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87067.289618.patch
Type: text/x-patch
Size: 1028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200903/42551fc8/attachment.bin>