[PATCH] D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable

Wed Sep 2 17:41:49 PDT 2020

MaskRay added a comment.

In D83530#2253602 <https://reviews.llvm.org/D83530#2253602>, @Dor1s wrote:

> Please avoid landing changes like this in future. Either do the investigation and make sure everything is fixed (i.e. documentation updated, no compatibility changes), or do not remove stuff silently like this.

I have mentioned that (nearly one month ago) it was my omission and I apologized for that.

> Fangrui, what made you think it's fine to remove documented options and break compatibility for the users of the tool?

I don't think the option is properly documented, though. This is a large refactoring and it is difficult to ensure every option is good. I had tried very hard as you can probably see from the history of this patch. I shall also mention that this option is a completed untested feature so I somehow missed it. To be more constructive, do you have a use case whether this option or its inverse is needed?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83530/new/

https://reviews.llvm.org/D83530