[PATCH] D86892: Improve error handling for SmallVector programming errors.

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey marked an inline comment as done.
GMNGeoffrey added a comment.

In D86892#2253328 <https://reviews.llvm.org/D86892#2253328>, @MaskRay wrote:

> In D86892#2253324 <https://reviews.llvm.org/D86892#2253324>, @GMNGeoffrey wrote:
>
>> If y'all are good with this now (and think that others will not have objects), could one of you land it for me? I don't have commit access.
>
> Will do:) You can drop ` NOLINTNEXTLINE(readability-identifier-naming)`. The issues are known and are everywhere... Just ignore them and don't bother annotating the code...

I did that because without it the whole premerge check is reported as failing :-( I can drop them, but I wasn't even sure it wasn't masking some other error.

Seems that "build fails" and "clang-tidy fails and has commented" should not be the same failing check :-P


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86892/new/

https://reviews.llvm.org/D86892