[PATCH] D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 2 14:38:28 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:603
+ const int Multiply =
+ (EntryDistanceFromTOCBase - PositiveTOCRange) / TOCRange + 1;
+ return MCBinaryExpr::createAdd(
----------------
jasonliu wrote:
> Xiangling_L wrote:
> > Can we add an assertion here to make sure `EntryDistanceFromTOCBase - PositiveTOCRange` do not go beyond `-0x8000`?
> `EntryDistanceFromTOCBase - PositiveTOCRange` is always going to be a positive number. So not sure why we would need an assertion for it to be >= 0x8000?
Sorry, I mean >= -0x8000
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86879/new/
https://reviews.llvm.org/D86879
More information about the llvm-commits
mailing list