[PATCH] D86883: [X86] Add support for using fast short rep mov for memcpy lowering.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3112
+  assert(Src.getValueType() == Dst.getValueType());
+  SDValue SizeNode = DAG.getConstant(Flags.getByValSize(), dl, Src.getValueType());
 
----------------
yamauchi wrote:
> craig.topper wrote:
> > Maybe just use getIntPtrConstant instead of getConstant?
> My bad. This should actually be an int const rather than an int pointer const. Will change it to check if it's 64 bit instead.
IntPtrConstant is an integer the width of a pointer which I think is what we want.

You can't check for i64 being legal. That doesn't work for GNUX32 or NaCl which use 32-bit pointers on 64 bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86883/new/

https://reviews.llvm.org/D86883