[PATCH] D69411: [MC] Resolve the difference of symbols in consecutive MCDataFragements

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D69411#2252965 <https://reviews.llvm.org/D69411#2252965>, @nickdesaulniers wrote:

> With this patch applied, I no longer observe the error from https://github.com/ClangBuiltLinux/linux/issues/742 for 32b ARM, though I can't do a full kernel build with Clang's IA yet due to missing support for the `adrl` pseudo instruction. (https://github.com/ClangBuiltLinux/linux/issues/430, https://bugs.llvm.org/show_bug.cgi?id=24350) in order to boot test.  I did boot test x86 (32b and 64b) and arm64 Linux kernels with this change just fine (using Clang's integrated assembler).
>
> It looks like there may have been unresolved comments from @MaskRay .  I'm also curious whether @jyknight or @psmith had parting thoughts? (@jcai19 maybe wait a week for their feedback?)

I am waiting on @jyknight's opinion about the potentially subtle `unsigned SubsectionNumber = 0;` (at the very least, if we want to keep it, it should be reordered as my comment says, and don't repeat the name of the variable)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411