[PATCH] D86904: [mlir] [InProgress] Support for defining Types in tblgen

[Sean Silva via Phabricator via llvm-commits]

silvas added inline comments.


================
Comment at: llvm/lib/Support/Hashing.cpp:30
+
+hash_code llvm::hash_value(float value) {
+  return hash_value(*(uint32_t *)&value);
----------------
silvas wrote:
> Drive-by comment: this actually is not a correct hashing implementation. it can result in x == y yet have hash(x) != hash(y) and other violation of invariants. (consider negative 0 and NaN's) 
more details here: https://research.swtch.com/randhash


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86904/new/

https://reviews.llvm.org/D86904