[PATCH] D86839: [CMake] Remove -Wl,-allow-shlib-undefined which was added in rL221530

Wed Sep 2 11:39:09 PDT 2020

MaskRay added a comment.

In D86839#2252640 <https://reviews.llvm.org/D86839#2252640>, @bjope wrote:

> So are we perhaps missing tinfo (and ncurses) in /proj/bbi_twh/wh_bbi/x86_64-Linux2/bbigcc/1.7.4.0-3/crosscompiler/lib64?

Yes

> I doubt that we should pick up libtinfo from /usr/lib64 here, even if we do not really need to crosscompile llvm-tblgen (tblgen should only execute on the current host anyway).
>
> (BTW, thing do work fine when building with clang and for the current host, so it is something with the crosscompile setup...  a bit interesting that it has worked in the past though...)

It worked likely because libtinfo.so does not set DF_BIND_NOW or DF_1_NOW. `LD_BIND_NOW=1 linked-exe` would likely fail.

In D86839#2252675 <https://reviews.llvm.org/D86839#2252675>, @bjope wrote:

> Things seem to link again for us if we set LLVM_ENABLE_TERMINFO=OFF (as a workaround to avoid dependency to libtinfo), but I guess we might lose some color output or something by doing that.

LLVMSupport uses terminfo to check whether the terminal supports colors. Yes, -DLLVM_ENABLE_TERMINFO=OFF if terminfo is not available.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86839/new/

https://reviews.llvm.org/D86839