[PATCH] D84822: Add documentation for target ID and ClangOffloadBundlerFormat

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:830
                                                   :ref:`amdgpu-ef-amdgpu-mach-table`.
      ``EF_AMDGPU_XNACK``               0x00000100 Indicates if the ``xnack``
                                                   target feature is
----------------
EF_AMDGPU_FEATURE_XNACK_V3 


================
Comment at: llvm/docs/AMDGPUUsage.rst:841
                                                   :ref:`amdgpu-target-features`.
-     ``EF_AMDGPU_SRAM_ECC``            0x00000200 Indicates if the ``sram-ecc``
+     ``EF_AMDGPU_SRAMECC``             0x00000200 Indicates if the ``sramecc``
                                                   target feature is
----------------
EF_AMDGPU_FEATURE_SRAMECC_V3 


================
Comment at: llvm/docs/AMDGPUUsage.rst:867
+                                                  :ref:`amdgpu-ef-amdgpu-mach-table`.
+     ``EF_AMDGPU_FEATURE_XNACK``       0x00000300 XNACK selection mask for
+                                                  ``EF_AMDGPU_FEATURE_XNACK_xxx`` values
----------------
EF_AMDGPU_FEATURE_XNACK_V4 


================
Comment at: llvm/docs/AMDGPUUsage.rst:867
+                                                  :ref:`amdgpu-ef-amdgpu-mach-table`.
+     ``EF_AMDGPU_FEATURE_XNACK``       0x00000300 XNACK selection mask for
+                                                  ``EF_AMDGPU_FEATURE_XNACK_xxx`` values
----------------
kzhuravl wrote:
> EF_AMDGPU_FEATURE_XNACK_V4 
EF_AMDGPU_FEATURE_XNACK_V3 


================
Comment at: llvm/docs/AMDGPUUsage.rst:871
+                                                  :ref:`amdgpu-ef-amdgpu-feature-xnack-table`.
+     ``EF_AMDGPU_FEATURE_SRAMECC``      0x00000c00 SRAMECC selection mask for
+                                                  ``EF_AMDGPU_FEATURE_SRAMECC_xxx`` values
----------------
EF_AMDGPU_FEATURE_SRAMECC_V4 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822