[PATCH] D87001: [IRMover] Avoid materializing global value that belongs to not-yet-linked module

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 10:53:54 PDT 2020


ychen added a comment.

In D87001#2252711 <https://reviews.llvm.org/D87001#2252711>, @tejohnson wrote:

> I need to think through this some more, but a couple questions:
>
> Was the clang self host that you tried regular or Thin LTO? If regular please also try ThinLTO.

I was testing the patch with regular LTO. Will try ThinLTO also.

> Do you have a test case showing the failure you got? I think it will be important to add if at all possible.

The original test case is pretty big. I'll try harder to get it reduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87001/new/

https://reviews.llvm.org/D87001



More information about the llvm-commits mailing list