[PATCH] D86952: [MIRVRegNamer] MachineInstr StableHashing.

[Nathan Lanza via Phabricator via llvm-commits]

lanza added a comment.

Other than the one comment LGTM.



================
Comment at: llvm/lib/CodeGen/MachineStableHash.cpp:151
+/// A stable hash value for machine instructions.
+/// Returns 0 if no stable hash could be computed.
+/// The hashing and equality testing functions ignore definitions so this is
----------------
That seems kinda error prone. `VRegRenamer::getInstructionOpcodeHash` would just propagate forward a failure blindly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86952/new/

https://reviews.llvm.org/D86952