[PATCH] D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19).

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Might be too fine-grained and better off rolled into whatever patch exercises this functionality when emitting assembly.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DIE.cpp:479
   case dwarf::DW_FORM_sec_offset:
-    // FIXME: add support for DWARF64
-    return 4;
+    return AP->isDwarf64() ? 8 : 4;
   default:
----------------
did one of your other patches added a function to AsmPrinter to get the size directly, rather than having to query the version then compute the size from that? (or maybe you added that to MCStreamer) Would be nice to avoid rewriting this code to compute size from DWARF64-ness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87009/new/

https://reviews.llvm.org/D87009