[PATCH] D87033: [APInt] New member function setBitTo

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 09:01:51 PDT 2020


lebedev.ri added a comment.

LGTM



================
Comment at: llvm/include/llvm/ADT/APInt.h:1454
+  /// Set a given bit to a given value.
+  void setBitTo(unsigned BitPosition, bool BitValue) {
+    assert(BitPosition < BitWidth && "BitPosition out of range");
----------------
I think `setBitVal()` might be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87033/new/

https://reviews.llvm.org/D87033



More information about the llvm-commits mailing list