[PATCH] D86995: [VectorCombine][SVE] Do not fold bitcast shuffle for scalable type.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:437
+  // mask for scalable type is a splat or not.
+  if (isa<ScalableVectorType>(SrcTy) || isa<ScalableVectorType>(DestTy))
+    return false;
----------------
Change to dyn_cast<FixedVectorType> above this instead of adding isa<> checks?


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:446-447
 
   // FIXME: it should be possible to implement the computation of the widened
   // shuffle mask in terms of ElementCount to work with scalable shuffles.
   unsigned DestNumElts = cast<FixedVectorType>(DestTy)->getNumElements();
----------------
Move this comment to up to the point that we are excluding ScalableVectorType.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86995/new/

https://reviews.llvm.org/D86995