[PATCH] D86989: [InstCombine] Fix a couple crahses with extractelement on a scalable vector.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 00:40:06 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2573
+      unsigned NumElts = VecTy->getNumElements();
+      APInt DemandedVecElts = APInt::getAllOnesValue(NumElts);
+      if (CIdx && CIdx->getValue().ult(NumElts))
----------------
david-arm wrote:
> sdesmalen wrote:
> > nit: is this how whitespace changes are rendered after the latest Phabricator update, or are these tabs?
> I've seen these rendered on mine and other patches too where there are no tabs. I think it's the latest Phabricator update showing indentation.
Good to know, that's a nice improvement to Phabricator! Thanks for confirming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86989/new/

https://reviews.llvm.org/D86989



More information about the llvm-commits mailing list