[PATCH] D86989: [InstCombine] Fix a couple crahses with extractelement on a scalable vector.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 2 00:33:44 PDT 2020
sdesmalen accepted this revision.
sdesmalen added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2573
+ unsigned NumElts = VecTy->getNumElements();
+ APInt DemandedVecElts = APInt::getAllOnesValue(NumElts);
+ if (CIdx && CIdx->getValue().ult(NumElts))
----------------
nit: is this how whitespace changes are rendered after the latest Phabricator update, or are these tabs?
================
Comment at: llvm/test/Transforms/InstCombine/vscale_extractelement.ll:168
+;
+entry:
+ %ext = extractelement <vscale x 2 x i32> %d, i32 0
----------------
nit: `entry:` can be removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86989/new/
https://reviews.llvm.org/D86989
More information about the llvm-commits
mailing list