[PATCH] D86610: [ELF] Add new EM called EM_CSKY

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 21:25:16 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/CSKY.def:6
+
+ELF_RELOC(R_CKCORE_NONE                 ,       0)
+ELF_RELOC(R_CKCORE_ADDR32               ,       1)
----------------
For relocation type changes, we have tests in test/tools/llvm-readobj/ELF/reloc-types-elf-*.test. I don't know replicating every value is useful (you'll probably just copy and paste the value anyway), but having a few should not hurt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86610/new/

https://reviews.llvm.org/D86610



More information about the llvm-commits mailing list