[PATCH] D86998: [llvm-dwarfdump] Warn user when it encounters no null terminated strings.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:533
+    Error Err = Error::success();
+    cantFail(std::move(Err));
+
----------------
`operator bool` sets the checked state if Error is in a success state.

So you can just run: `(void)!Err`

If you want to ensure an Error in a success state is also checked (not in this case), `ErrorAsOutParameter ...(&Err)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86998/new/

https://reviews.llvm.org/D86998