[PATCH] D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructor

Yang Fan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 19:37:43 PDT 2020


nullptr.cpp added a comment.

In D86997#2251233 <https://reviews.llvm.org/D86997#2251233>, @craig.topper wrote:

> What problem does this cause? IEEEFloat::initFromFloatAPInt which is called for IEEEFloat::IEEEFloat(float f) also doesn't assign exponent from what I can see.

I found this by a static analyzer checker, I’m just worried if an uninitialized variable is used somewhere before initialization.
Should we initialize it or just leave it as it is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86997/new/

https://reviews.llvm.org/D86997



More information about the llvm-commits mailing list