[PATCH] D86383: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _)

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In D86383#2250882 <https://reviews.llvm.org/D86383#2250882>, @rupprecht wrote:

> Thanks!
>
> Usually, tests that are marked `# REQUIRES: asserts` are done so because they make use of some code that is only available behind `NDEBUG`. However, in this case, it's outright crashing on certain inputs when not in debug mode. At a first glance, that doesn't seem like a correct fix to me -- after all, the crashing bug is still there -- but I'm not familiar with this code, so I'm probably missing something?

There's no bug in the actual patch, the crash is because the testing flag `--aarch64prelegalizercombinerhelper-only-enable-rule` doesn't work without assertions enabled. It's not an elegant failure mode, but nothing to worry I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86383/new/

https://reviews.llvm.org/D86383