[PATCH] D86608: [LLD][PowerPC] Add support for TLS Local Exec

Tue Sep 1 13:20:56 PDT 2020

NeHuang added inline comments.

================
Comment at: lld/test/ELF/ppc64-tls-pcrel-le.s:3
+# RUN: echo 'SECTIONS { \
+# RUN:   .text_addr  0x10010000 : { *(.text_addr) } \
+# RUN:   .text_value 0x10020000 : { *(.text_value) } \
----------------
Do we need the address set up for this case? Seems we are not checking/verifying the offset using in the `paddi` to access `x`, `y` and `z`

================
Comment at: lld/test/ELF/ppc64-tls-pcrel-le.s:54
+
+LocalExecAddrY:
+	paddi 3, 13, y at TPREL, 0
----------------
what is the test purpose of adding symbol y, it seems identical as the case for symbol x?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86608/new/

https://reviews.llvm.org/D86608