[PATCH] D86957: [Bitstream] Use alignTo to make code more readable. NFC
stephan.yichao.zhao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 1 11:09:50 PDT 2020
stephan.yichao.zhao added a comment.
So this does both 64bit cast and alignment. Thank you.
Hi Craig, in your case, will NumElts be actually larger than 2^32? NumElts is read from https://llvm.org/docs/BitCodeFormat.html#enter-subblock-encoding that defines the blocklen to be 32bit. So when it gets larger, the overflow can happen at the writer side (https://llvm.org/doxygen/BitstreamWriter_8h_source.html#l00384).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86957/new/
https://reviews.llvm.org/D86957
More information about the llvm-commits
mailing list