[PATCH] D86956: [AArch64LoadStoreOptimization] Bug fix in ldr to ldp conversion

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 09:59:16 PDT 2020


congzhe added a comment.

In D86956#2249916 <https://reviews.llvm.org/D86956#2249916>, @fhahn wrote:

> Is it possible to add a MIR test for the issue? Also, it looks like the formatting is off a bit. Could you run clang-format-diff on the change?

Thanks! Regarding the MIR test: similar to the test file in the other patch https://reviews.llvm.org/D86906, the MIR test file for this patch is very lengthy (over 1000 lines). I'm wondering if it looks fine if I use that test file, or I could spend time trying to prune it, although I'm not optimistic how much it can be reduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86956/new/

https://reviews.llvm.org/D86956



More information about the llvm-commits mailing list