[PATCH] D86906: [AArch64LdStOptimzation] fix a bug in AArch64 Load Store Optimization

Tue Sep 1 09:49:29 PDT 2020

congzhe added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-ldst-subsuperReg-no-ldp.mir:187
+  bb.0.entry:
+    renamable $x8 = ADRP target-flags(aarch64-page) @o
+    renamable $w10 = LDRWui killed renamable $x8, target-flags(aarch64-pageoff, aarch64-nc) @o :: (dereferenceable load 4 from `i32* getelementptr inbounds ([1 x [8 x i32]], [1 x [8 x i32]]* @o, i64 0, i64 0, i64 0)`, !tbaa !2)
----------------
fhahn wrote:
> Are all the loads/stores and the different BBs needed for the test? Also, are the different functions needed or do they test different scenarios?
Thanks for the comment!
The different functions do not test different scenarios. This is one single program (one single test) that exposes the bug, so probably all functions/BBs are still needed but I can try to reduce the program. I'm not very hopeful though because this test file is already a very much reduced version compared to its original version.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86906/new/

https://reviews.llvm.org/D86906