[PATCH] D86913: Add raw_fd_stream that supports reading/seeking/writing
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 1 09:05:00 PDT 2020
JDevlieghere added a comment.
Other than a small style nit this LGTM
================
Comment at: llvm/lib/Support/raw_ostream.cpp:920
+ // Do not support STDOUT_FILENO and non-seekable files.
+ if (Filename == "-" || !supportsSeeking()) {
+ EC = std::make_error_code(std::errc::invalid_argument);
----------------
nit: the llvm style guide says no braces around single-line statements. Same in `raw_fd_stream::read` below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86913/new/
https://reviews.llvm.org/D86913
More information about the llvm-commits
mailing list