[PATCH] D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call.

[Hamilton Tobon Mosquera via Phabricator via llvm-commits]

hamax97 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:511
+    // Get setup instruction for %offload_baseptrs.
+    if (!getSetupInstructions(OffloadArrays[0]))
+      return false;
----------------
sstefan1 wrote:
> I think it would be useful to make these constants with proper names, eg. `constexpr int OffloadPtrsIdx = 0;` or something similar. WDYT?
I thought abot that but I didn't do it because it might've been too descriptive. Perhaps as attributes of `MemoryTransfer` would be even better, WDYT?.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86474/new/

https://reviews.llvm.org/D86474