[PATCH] D84403: [AMDGPU] Use ds_read/write_b96/b128 when possible for SDag

Tue Sep 1 06:16:39 PDT 2020

mareko added a comment.

In D84403#2248880 <https://reviews.llvm.org/D84403#2248880>, @mbrkusanin wrote:

> In D84403#2248536 <https://reviews.llvm.org/D84403#2248536>, @mareko wrote:
>
>> This breaks LDS. LLVMSetAlignment(inst, 4) on loads and stores has no effect. The IR says "align 4", yet the backend still selects b128.
>
> On what subtargets? GFX9 and 10 should select b128 for align 4. That is the purpose of the patch. Are you saying it selects it for SI, CI or VI?

On GFX10. Apparently b128 with align 4 doesn't work there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84403/new/

https://reviews.llvm.org/D84403