[PATCH] D86905: Flush bitcode incrementally for LTO output

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 05:19:29 PDT 2020


evgeny777 added inline comments.


================
Comment at: llvm/include/llvm/Bitstream/BitstreamWriter.h:157
+    {
+      FS->seek(ByteNo);
+      ssize_t BytesRead = FS->read(Bytes, BytesFromDisk);
----------------
Can we use memory mapped I/O and avoid backpatching on disk?


================
Comment at: llvm/include/llvm/Support/raw_ostream.h:570
+
+/// A raw_ostream that reads from, writes to and seeks a file descriptor.
+///
----------------
Comment is misleading


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86905/new/

https://reviews.llvm.org/D86905



More information about the llvm-commits mailing list